There's no wrong time to write a thank-you card for a teacher, but it's customary to write a note around the holidays, at the end of the year, when they retire or during Teacher Appreciation Week.